fix: ignore branch merges with multiple newlines (#227)

conventional-changelog · Jan 12, 2018 · 1f0c5ca · 1f0c5ca
1 parent 8ff5be2
commit 1f0c5ca
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/@commitlint/is-ignored/src/index.js b/@commitlint/is-ignored/src/index.js
@@ -3,7 +3,7 @@ import semver from 'semver';
 const WILDCARDS = [
 	c =>
 		c.match(
-			/^(Merge pull request)|(Merge (.*?) into (.*?)|(Merge branch (.*?))(?:\r?\n)?$)/
+			/^(Merge pull request)|(Merge (.*?) into (.*?)|(Merge branch (.*?))(?:\r?\n)*$)/
 		),
 	c => c.match(/^(R|r)evert (.*)/),
 	c => c.match(/^(fixup|squash)!/),

diff --git a/@commitlint/is-ignored/src/index.test.js b/@commitlint/is-ignored/src/index.test.js
@@ -52,6 +52,11 @@ test('should return true for branch merges with newline characters', t => {
 	t.true(isIgnored("Merge branch 'ctrom-YarnBuild'\r\n"));
 });
 
+test('should return true for branch merges with multiple newline characters', t => {
+	t.true(isIgnored("Merge branch 'ctrom-YarnBuild'\n\n\n"));
+	t.true(isIgnored("Merge branch 'ctrom-YarnBuild'\r\n\r\n\r\n"));
+});
+
 test('should return true for merged PRs', t => {
 	t.true(isIgnored('Merge pull request #369'));
 });