Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): add support for GIT_PARAMS on windows. Closes #103 #175

Merged

Conversation

kumarharsh
Copy link
Contributor

@kumarharsh kumarharsh commented Dec 5, 2017

Description

The commit adds a new special parser for the edit flag for Windows,
so that $GIT_PARAMS can be read from the command-line

Motivation and Context

commitlint on Windows doesn't work when $GIT_PARAMS are
specified in the package.json file.

#103

Usage examples

// commitlint.config.js
module.exports = {
  extends: ["@commitlint/config-conventional"]
};
// package.json
{
  ...
  "scripts": {
    "commitmsg": "commitlint -e $GIT_PARAMS"
  }
}

How Has This Been Tested?

Edit:

  • new integration tests added

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marionebl
Copy link
Contributor

marionebl commented Dec 5, 2017

I took the liberty to add two new test cases (that were missing in the first place) and added a comment to the implementation explaining why this is needed.

Thanks for your work!

@marionebl marionebl merged commit c62bd41 into conventional-changelog:master Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants