Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): avoid linebreak in empty input #523

Conversation

escapedcat
Copy link
Member

@escapedcat escapedcat commented Dec 17, 2018

Description

As discussed we can trim the empty input to invalidate an input which per default comes as \n.

Motivation and Context

#511

How Has This Been Tested?

I need help here. We have this test but I'm not sure what is being tested here. It worked before and still works...

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marionebl marionebl merged commit 3141882 into conventional-changelog:master Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants