You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've been working on a plugin to validate footers, however it seems that comments (lines starting with #) are not removed by the parser, perhaps because of a missing parser preset.
I found this issue #78 that mentions switching to a fork of the parser, but for some reason this doesn't seem to be working for me.
Expected Behavior
I would expect any comments to be stripped by the parser, such that they won't interfere with any rules.
Current Behavior
Currently the parser does not remove any comments, which means that the commit message template I'm using will make various rules fail. The standard output by git showing which files have been modified etc when writing a commit message using git commit, are thus also present and will make certain rules fail.
Affected packages
cli
core
prompt
config-angular
Possible Solution
Any line starting with a # should be stripped by the parser.
Steps to Reproduce (for bugs)
Install @commitlint/cli, @commitlint/config-conventional (and optionally my plugin commitlint-plugin-cleanfeet)
Remove parserPreset (since this currently results in a module not found error, see other issue)
Add any lines starting with # when using git commit
I've been working on a plugin to validate footers, however it seems that comments (lines starting with
#
) are not removed by the parser, perhaps because of a missing parser preset.I found this issue #78 that mentions switching to a fork of the parser, but for some reason this doesn't seem to be working for me.
Expected Behavior
I would expect any comments to be stripped by the parser, such that they won't interfere with any rules.
Current Behavior
Currently the parser does not remove any comments, which means that the commit message template I'm using will make various rules fail. The standard output by git showing which files have been modified etc when writing a commit message using
git commit
, are thus also present and will make certain rules fail.Affected packages
Possible Solution
Any line starting with a
#
should be stripped by the parser.Steps to Reproduce (for bugs)
@commitlint/cli
,@commitlint/config-conventional
(and optionally my plugincommitlint-plugin-cleanfeet
)parserPreset
(since this currently results in a module not found error, see other issue)#
when usinggit commit
commitlint.config.js
Your Environment
commitlint --version
git --version
node --version
The text was updated successfully, but these errors were encountered: