Skip to content

Commit

Permalink
fix(cli): Remove broken error handling
Browse files Browse the repository at this point in the history
data.state is not available when using Q.all() and only works with Q.allSettled().
As Q.all() is now used it does not make sense to do this check as the Promise
will be rejected immediately with an error if one of the calls to github fails.
  • Loading branch information
danez authored Sep 1, 2017
1 parent 757fed0 commit 4b981f7
Showing 1 changed file with 1 addition and 13 deletions.
14 changes: 1 addition & 13 deletions src/cli.js
Original file line number Diff line number Diff line change
Expand Up @@ -115,19 +115,7 @@ conventionalGithubReleaser({
process.exit(0);
}

var allRejected = true;

for (var i = data.length - 1; i >= 0 ; i--) {
if (data[i].state === 'fulfilled') {
allRejected = false;
break;
}
}

if (allRejected) {
console.error(data);
process.exit(1);
} else if (flags.verbose) {
if (flags.verbose) {
console.log(data);
}
});

0 comments on commit 4b981f7

Please sign in to comment.