Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load from Gitlab #11

Open
cophilot opened this issue Aug 18, 2024 · 5 comments · May be fixed by #14
Open

Load from Gitlab #11

cophilot opened this issue Aug 18, 2024 · 5 comments · May be fixed by #14
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@cophilot
Copy link
Owner

The load command takes a GitHub URL to fetch some predefined templates from a repository. This should also be possible with a Gitlab repository URL. The functionality should not be changes and for the user it should not make a difference if it is a GitHub or a Gitlab URL.

Use this Gitlab repo for testing purposes.

@cophilot cophilot added enhancement New feature or request help wanted Extra attention is needed labels Aug 18, 2024
@cophilot
Copy link
Owner Author

This is a bit harder issue and involves some more complex operations, like fetching data over an API, but if you want, I think it would be a good issue for your @RounakJoshi09 :)

@RounakJoshi09
Copy link
Contributor

Sure thing @cophilot , I would definitely take this up and solve it asap.
Thanks for assigning,

@cophilot
Copy link
Owner Author

Sure thing @cophilot , I would definitely take this up and solve it asap.
Thanks for assigning,

Thanks and don't hurry @RounakJoshi09 take your time. It is not urgent...

@cophilot cophilot added this to the v2.0.0 milestone Aug 18, 2024
@RounakJoshi09
Copy link
Contributor

RounakJoshi09 commented Sep 10, 2024

Hi @cophilot , hope you're having a great week.
I have almost completed with the functionality (PR #14) , just have to write test cases for the implemented feature.
For that purpose can you please add Test template in this gitlab repository https://gitlab.com/cophilot/templify-vault,
as it is present in GitHub Repository, so that I can reuse the existing tests of load. Adding the Link of Test Template FYR
https://github.com/cophilot/templify-vault/tree/main/Test
Thanks,

@cophilot
Copy link
Owner Author

Hi @RounakJoshi09
Thank you for that! I will look into the PR in the next few days when I find the time for it :)
I just added everything to https://gitlab.com/cophilot/templify-vault
Let me know if you need anything else!

@cophilot cophilot linked a pull request Oct 28, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants