You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I tried to compile and run coraza on windows, which obiously failed.
I know that windows is not a supported platform, but I like to contribute patches to improve the situation. Currently, I am able to pass all tests on windows except those requiring go-ftw (which also does not work on windows). I also ran the tests on linux and the changes did not have any negative impact.
IMHO these patches also improve code quality for other platforms, as they mostly fix incorrect behaviour of not properly closed files and expected behaviour of filepath.Clean/path.Join.
I have created several pull requests to make reviewing easier.
Steps to reproduce
run windows (or wine?)
go run mage.go test
Expected result
all tests pass
Actual result
Some tests fail. Mostly because of filesystem behaviour differences.
PR
#1133 fix: broken TestInspectFile on windows #1135 fix: broken embedio on windows #1132 fix: broken TestDirectives SecUploadDir on windows #1134 fix: broken normalisePath/normalisePathWin on windows #1137 fix: broken mutlipart processor on windows #1136 fix: broken TestHardcodedIncludeDirectiveDDOS2 on windows #1138 fix: broken TestConcurrentWriterSuccess on windows #1139 fix: broken unclosed files on windows
The text was updated successfully, but these errors were encountered:
Description
I tried to compile and run coraza on windows, which obiously failed.
I know that windows is not a supported platform, but I like to contribute patches to improve the situation. Currently, I am able to pass all tests on windows except those requiring go-ftw (which also does not work on windows). I also ran the tests on linux and the changes did not have any negative impact.
IMHO these patches also improve code quality for other platforms, as they mostly fix incorrect behaviour of not properly closed files and expected behaviour of filepath.Clean/path.Join.
I have created several pull requests to make reviewing easier.
Steps to reproduce
Expected result
all tests pass
Actual result
Some tests fail. Mostly because of filesystem behaviour differences.
PR
#1133 fix: broken TestInspectFile on windows
#1135 fix: broken embedio on windows
#1132 fix: broken TestDirectives SecUploadDir on windows
#1134 fix: broken normalisePath/normalisePathWin on windows
#1137 fix: broken mutlipart processor on windows
#1136 fix: broken TestHardcodedIncludeDirectiveDDOS2 on windows
#1138 fix: broken TestConcurrentWriterSuccess on windows
#1139 fix: broken unclosed files on windows
The text was updated successfully, but these errors were encountered: