Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation warning for newer Express versions #6

Open
konklone opened this issue Sep 17, 2014 · 2 comments
Open

Deprecation warning for newer Express versions #6

konklone opened this issue Sep 17, 2014 · 2 comments

Comments

@konklone
Copy link 

GMT express deprecated res.send(status, body): 

Use res.status(status).send(body) instead at node_modules/hookshot/lib/index.js:33:9

Seems like an easy enough fix. I feel like your testing setup for webhooks is probably more ready-to-go than mine, but if you'd prefer a PR I can probably do one at some point.
@mhkeller
Copy link

+1

@mdsteveb
Copy link

mdsteveb commented Dec 6, 2017

See PR #16 that I just submitted .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@konklone @mhkeller @mdsteveb