Skip to content
This repository has been archived by the owner on Mar 28, 2020. It is now read-only.

backup operator: fixed incorrect backup file naming convention. #2075

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kapouille
Copy link
Contributor

When limiting the number of backups, if the revision would move to needing another digit, the logic would never select a new entry as _ is > to 9 in ascii terms.

Note that this is backwards incompatible as now files receive a correct padding and old revisions will still be incorrectly handled.

@etcd-bot
Copy link
Collaborator

etcd-bot commented Apr 5, 2019

Can one of the admins verify this patch?

2 similar comments
@etcd-bot
Copy link
Collaborator

etcd-bot commented Apr 5, 2019

Can one of the admins verify this patch?

@etcd-bot
Copy link
Collaborator

etcd-bot commented Apr 5, 2019

Can one of the admins verify this patch?

@hexfusion
Copy link
Member

@etcd-bot ok to test

@mikenorgate
Copy link

@kapouille it looks like we missed this line in the tests

suffix := fmt.Sprintf("%d", rand.Uint64())

When limiting the number of backups, if the revision would move to needing another digit, the logic would never select a new entry as _ is > to 9 in ascii terms.

Note that this is backwards incompatible as now files receive a correct padding and old revisions will still be incorrectly handled.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants