Skip to content
This repository has been archived by the owner on Mar 28, 2020. It is now read-only.

ADDED: prometheus exporter for backup-operator #2096

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jescarri
Copy link

@jescarri jescarri commented Jun 17, 2019

Added prometheus exporter for the etcd-backup-operator.

@etcd-bot
Copy link
Collaborator

Can one of the admins verify this patch?

2 similar comments
@etcd-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@etcd-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@jescarri jescarri force-pushed the add_prometheus_metrics_backup branch from 89274f4 to c508235 Compare June 17, 2019 20:54
@jescarri
Copy link
Author

jescarri commented Jul 3, 2019

Hi @hexfusion any feedback on this PR?

Thanks!

@jescarri
Copy link
Author

jescarri commented Jul 9, 2019

@hasbro17 @hongchaodeng @xiang90 @fanminshi @rjtsdl

Hey guys sorry for the direct reach, can I get some help on this PR?.

Thanks!

@rjtsdl
Copy link
Contributor

rjtsdl commented Jul 9, 2019

LGTM overall, can we use basic http rather than introduce garrilia router? My point is, it is not exporting other path except /metrics. A simple http.Handle should be enough.

@jescarri jescarri force-pushed the add_prometheus_metrics_backup branch from c508235 to e4e63ab Compare July 11, 2019 03:58
Added a few metricts and an exporter to the backup operator.

Related to: coreos#2095

Removed gorilla mux
@jescarri jescarri force-pushed the add_prometheus_metrics_backup branch from e4e63ab to 6309d49 Compare July 11, 2019 04:01
@jescarri
Copy link
Author

@rjtsdl done, removed the gorilla mux dependency.

Copy link
Contributor

@rjtsdl rjtsdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you introduce a metrics port flag instead of hard code it? You can check how etcd-operator does.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants