clientv3: translate WithPrefix() into WithFromKey() for empty key #7752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanminshi
reviewed
Apr 17, 2017
| @@ -381,6 +381,36 @@ func TestKVRange(t *testing.T) { | |||
| {Key: []byte("fop"), Value: nil, CreateRevision: 9, ModRevision: 9, Version: 1}, | |||
| }, | |||
| }, | |||
| // fetch entire keyspace using WithFromKey | |||
| { | |||
| "\x00", "", | |||
There was a problem hiding this comment.
if the key is "" with the opt WithFromKey(), what's the expected behavior?
There was a problem hiding this comment.
It'll fail because no key is defined. No one complains about Get(ctx, "", WithFromKey())
Codecov Report
@@ Coverage Diff @@
## master #7752 +/- ##
=========================================
Coverage ? 75.71%
=========================================
Files ? 331
Lines ? 26011
Branches ? 0
=========================================
Hits ? 19693
Misses ? 4894
Partials ? 1424
Continue to review full report at Codecov.
|
|
lgtm |
1 similar comment
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users seem to expect the client to do this.