clientv3: set current revision to create rev regardless of CreateNotify #7804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out the optimization to ignore setting the init rev for current revision watches breaks some ordering assumptions. Since Watch only returns a channel once it gets a response, it should bind the revision at the time of the first create response. Was causing TestWatchReconnInit to fail.
Codecov Report
@@ Coverage Diff @@
## master #7804 +/- ##
=========================================
Coverage ? 75.63%
=========================================
Files ? 331
Lines ? 26148
Branches ? 0
=========================================
Hits ? 19778
Misses ? 4940
Partials ? 1430
Continue to review full report at Codecov.
|
|
we do not really say any thing about the ordering between watch and other calls from one client. but yea, i agree that this optimization might not worth the effort. the side-effect might be confusing. |
|
lgtm |
|
@heyitsanthony Do we backport this as well? This is following change after #7795? |
|
@gyuho yeah |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the optimization to ignore setting the init rev for
current revision watches breaks some ordering assumptions. Since
Watch only returns a channel once it gets a response, it should
bind the revision at the time of the first create response.
Was causing TestWatchReconnInit to fail.