-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mvcc: chunk reads for restoring #7900
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. /cc @xiang90
LGTM. Thanks. |
Loading all keys at once would cause etcd to use twice as much memory than it would need to serve the keys, causing RSS to spike on boot. Instead, load the keys into the mvcc by chunk. Uses pipelining for some concurrency. Fixes etcd-io#7822
This never worked.
2f59a60
to
1aca63e
Compare
Codecov Report
@@ Coverage Diff @@
## master #7900 +/- ##
=========================================
Coverage ? 75.82%
=========================================
Files ? 332
Lines ? 26332
Branches ? 0
=========================================
Hits ? 19966
Misses ? 4938
Partials ? 1428
Continue to review full report at Codecov.
|
Hey guys, any way we could get this released with 3.2? |
@davissp14 can you confirm this fixes the RSS spike? |
I'll give this a try this afternoon. |
Just confirming this did fix the RSS spike. Thanks guys. Also any thoughts on bringing this into 3.2 release? |
No objection from me. @xiang90 ? |
No objection. |
Loading all keys at once would cause etcd to use twice as much
memory than it would need to serve the keys, causing RSS to spike on
boot. Instead, load the keys into the mvcc by chunk. Uses pipelining
for some concurrency.
Fixes #7822
tmpfs benchmarks:
Before:
After: