Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3rpc: set Canceled=true on compacted watch #8283

Merged
merged 4 commits into from
Jul 26, 2017

Conversation

heyitsanthony
Copy link
Contributor

The change to the RPC needs client changes to avoid closing the channel without sending the compact revision; older clients will only see the close. Possible alternatives are either fake it entirely in the client, send two compact revision responses (one without the cancel, followed by one with), or change the documentation.

Fixes #8231

@xiang90
Copy link
Contributor

xiang90 commented Jul 20, 2017

lgtm

@heyitsanthony heyitsanthony merged commit 16943f0 into etcd-io:master Jul 26, 2017
gyuho added a commit to gyuho/etcd that referenced this pull request Nov 14, 2017
gyuho added a commit to gyuho/etcd that referenced this pull request Nov 14, 2017
gyuho added a commit to gyuho/etcd that referenced this pull request Nov 14, 2017
gyuho added a commit to gyuho/etcd that referenced this pull request Nov 14, 2017
gyuho added a commit to gyuho/etcd that referenced this pull request Nov 14, 2017
gyuho added a commit to gyuho/etcd that referenced this pull request Nov 14, 2017
gyuho added a commit to gyuho/etcd that referenced this pull request Nov 14, 2017
gyuho added a commit to gyuho/etcd that referenced this pull request Nov 14, 2017
gyuho added a commit to gyuho/etcd that referenced this pull request Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

WatchResponse.Canceled is not triggered to true
3 participants