Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctlv2: backup --with-v3 #8479

Merged
merged 3 commits into from
Sep 5, 2017
Merged

Conversation

heyitsanthony
Copy link
Contributor

Copy v3 db if given --with-v3. Strip out v3 entries from WAL by default.

Also strips out v3 data if not given --with-v3.
@heyitsanthony heyitsanthony force-pushed the ctlv2-backup-v3 branch 2 times, most recently from 7a892c2 to 079d578 Compare September 1, 2017 07:22
Anthony Romano added 2 commits September 1, 2017 00:24
Setting the ETCDCTL_API=3, then calling etcdctl was unwieldy and not
thread safe; all ctl v3 tests had to go through the ctlv3 wrapper and
could not easily mix with v2 commands.
Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants