*: allow user-provided watch ID to mvcc #9065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xiang90 PTAL. Added clientv3 watch response cancel field check (in addition to |
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
This allows for watchers to be created concurrently without needing potentially complex and latency-adding queuing on the client. Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #9065 +/- ##
=========================================
Coverage ? 76.08%
=========================================
Files ? 359
Lines ? 29959
Branches ? 0
=========================================
Hits ? 22794
Misses ? 5588
Partials ? 1577
Continue to review full report at Codecov.
|
Signed-off-by: Gyuho Lee <[email protected]>
|
lgtm |
|
@gyuho you might want to check with @fanminshi to make sure jetcd is not affected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smaller changes in server-side from #9015.
Plus, clientv3 change to handle non
-1watch ID (butCanceled==true).Watch ID is only configurable to mvcc/v3rpc for the use of other language client bindings.
Go
clientv3will still auto-generate watch IDs.Cherry-pick #8662.
Fix #7036.