Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop @cornerstonejs/nifti-image-loader #55

Open
kousu opened this issue Nov 29, 2022 · 0 comments
Open

Drop @cornerstonejs/nifti-image-loader #55

kousu opened this issue Nov 29, 2022 · 0 comments

Comments

@kousu
Copy link

kousu commented Nov 29, 2022

cornerstone-nifti-image-loader hasn't been updated in four years, since 1.0.0. The copy at @cornerstonejs/nifti-image-loader is up to 1.0.8, as of last month. I believe these are both from this same codebase; is that right?

I was confused by this since the rewrite of Cornerstone (which, remind me, is called "Cornerstone3D" to distinguish is from "CornerstoneJS"?) has made the move from cornerstone-core to @cornerstonejs/core, so I figured @cornerstonejs/nifti-image-loader would had also been part of the rewrite/migration. But you told me in #48 that that's not true. Also, when they made the move, they restarted their numbering at v0.0.1, but you didn't do the same, you just uploaded 1.0.1 as @cornerstonejs/nifti-image-loader and left the other name behind.

Your peer cornerstone-wado-image-loader doesn't seem to have made a similar migration yet, though it could since it's compatible with the new Cornerstone judging from the official tutorial (from the rewrite!!). Judging from the OHIF viewer, and this other cornerstone app, cornerstone-wado-image-loader is still very much alive and well and the 👍 recommended best practice DICOM loader 👍, and no one has migrated to @cornerstonejs/core yet, not even the team at OHIF who are writing it.

Right now my package.json is weirdly inconsistent because I want to use the latest versions of everything that work together which means mixing the @cornerstonejs/ namespace with the older unnamespaced cornerstone-core.

All that is to say, for clarity, can you go back to publishing to cornerstone-nifti-image-loader? Please upload 1.0.1, 1.0.2, 1.0.3, 1.0.4, 1.0.5, 1.0.6, 1.0.7 and 1.0.8 to that name and then continue on there, and delete @cornerstonejs/nifti-image-loader, at least until the port promised in #48 is actually ready, so other users avoid the confusion I had.

Thank you for all your hard work by the way! This is a pretty niche piece of software and I am extremely grateful and dependent on it. It's the only way I was able to make neuropoly/gitea#30 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant