-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove the need for slabThickness in volumeAPI for tools #113
Conversation
sedghi
commented
May 26, 2022
•
edited
Loading
edited
- Removes the need for slabThicknessEnabled
- Simplifies the API for setSlabThickness
- Fix bugs for volumeNewImageEventDispatcher
- Fix a bug for Synchronizer that triggered source viewport event when it didn't belong to the synchronizer anymore
- Fix RectangleROIStartEndThreshold tool various bugs with the new API
- Fix arrow tool to accept external api for change/set text
Nice fix. One comment: you set the infrastructure in crosshair to set the slabthickness by volumeIDs, but then in the petCt example you don't use it. You should exclude the pet volume from the third row of viewports. i.e. now the example renders like: but it should be (i.e., no slab thickness for the pet): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, I think the all-by-default or just use these isn't very clear in the API, and minor changes could fix that.
Otherwise I agree with Davide, the petCt example needs to be updated to reflect these changes.
packages/tools/src/tools/segmentation/RectangleROIStartEndThresholdTool.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment on demo, otherwise LGTM.