Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.0 Discussion #214

Open
yagni opened this issue Sep 27, 2022 · 1 comment
Open

Version 2.0 Discussion #214

yagni opened this issue Sep 27, 2022 · 1 comment
Milestone

Comments

@yagni
Copy link
Collaborator

yagni commented Sep 27, 2022

There are a couple of issues in the backlog that require a major version bump and could be beneficial, so I thought I'd get that process started. I created a milestone and added the issues there.

This issue is for discussion around 2.0 itself. Please discuss issue-specific details in the issues themselves.

@chafey @swederik @dannyrb @galelis (and anyone else) want to weigh in on what should/shouldn't be included in 2.0?

@yagni yagni added this to the 2.0 milestone Sep 27, 2022
@Ragnar-Oock
Copy link

I'm biased but maybe making the types more explicit (either by rewriting the lib in TS or by updating the type declaration like I proposed in #258 last year) would help when using the lib for advanced usage (i.e. not just throwing the file into cornerstone (legacy or 3d) for it to display the images on screen). The biggest pain point is the Element interface that has every possible element kinds merge into a single interface instead of the 4 different kinds that are actually returned by the parser (sequence elements, encapsulated PixelData element, FileMetaInformation element and the "basic" elements).
For an actual example use case I had to create a wrapper around dicom-parser to edit DICOM files (for anonymization mostly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants