Add improvement to tabbed page block configuration #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fajfa
requested changes
Sep 1, 2023
| @@ -152,6 +152,7 @@ | |||
| :bounding-rect="boundingRect" | |||
| editable | |||
| class="p-2" | |||
| @edit-tab-item-block="(index) => editBlock(index)" | |||
| @@ -146,3 +192,14 @@ export default { | |||
| }, | |||
| } | |||
| </script> | |||
|
|
|||
| <style scoped> | |||
| .tab-menu-item-tool { | |||
There was a problem hiding this comment.
Try to use only bootstrap except for text color when pills and active
| /> | ||
| </b-button> | ||
|
|
||
| <b-button |
There was a problem hiding this comment.
Use input confirm like toolbox does
Fajfa
requested changes
Sep 4, 2023
| <b-button | ||
| :variant="block.options.style.appearance === 'pills' ? 'secondary' : 'primary'" | ||
| size="sm" | ||
| @click="onTabMenuEditItemClick(tab)" |
|
|
||
| <c-input-confirm | ||
| class="ml-1" | ||
| @confirmed="onTabMenuDeleteItemClick(index)" |
Fajfa
requested changes
Sep 5, 2023
| <b-button | ||
| size="sm" | ||
| variant="outline-light" | ||
| class="edit-block-btn" |
There was a problem hiding this comment.
Just to keep it simple, you can do text-primary border-0 edit-block-btn
And just overwrite the color in the custom class
.tabs-base-block-container .nav-pills {
&.active .edit-block-btn {
color: $white !important;
}
}
Fajfa
approved these changes
Sep 5, 2023
kelanik8
force-pushed
the
2023.3.x-feature-improve-tab-pg-configuration
branch
from
06946e6
to
e66723d
Compare
|
Fajfa
requested changes
Oct 16, 2023
| const { blockID } = this.blocks[blockIndex] | ||
|
|
||
| if (!blockID) return | ||
|
|
There was a problem hiding this comment.
Not sure why you have to loop through them, you have the index and the tabIndex, so that's all you need to splice it
| > | ||
| <div | ||
| v-if="unsavedBlocks.has(tab.block.blockID !== '0' ? tab.block.blockID : tab.block.meta.tempID)" | ||
| :title="$t('tooltip.unsavedChanges')" |
| @@ -653,6 +656,20 @@ export default { | |||
|
|
|||
| this.blocks.splice(this.editor.index, 1, block) | |||
| this.unsavedBlocks.add(fetchID(block)) | |||
|
|
|||
| // Add the block that is a parent block is a tab to unsaved blocks registry0 | |||
| this.blocks.forEach((block) => { | |||
There was a problem hiding this comment.
You dont need to do this, you can just add the parent block when you delete a tab.
Fajfa
approved these changes
Oct 17, 2023
kelanik8
force-pushed
the
2023.3.x-feature-improve-tab-pg-configuration
branch
from
572af9c
to
1e232a6
Compare
|
Issue:
|
Fajfa
approved these changes
Oct 23, 2023
kelanik8
force-pushed
the
2023.3.x-feature-improve-tab-pg-configuration
branch
from
11cb415
to
31bc22d
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes are implemented
TODO: Summary
Changes in the user interface:
TODO: Add screenshots, recordings or remove this section
Checklist when submitting a final (!draft) PR