From ea01b91958766075b5461a5017a53ab681f33e42 Mon Sep 17 00:00:00 2001 From: ValarDragon Date: Mon, 3 Sep 2018 22:53:07 -0700 Subject: [PATCH] baseapp: Remove baseapp.SetTxDecoder() Closes #1441 --- PENDING.md | 1 + baseapp/setters.go | 6 ------ 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/PENDING.md b/PENDING.md index 17616ced1a4d..3fcf0b3b38ae 100644 --- a/PENDING.md +++ b/PENDING.md @@ -35,6 +35,7 @@ BREAKING CHANGES * [x/slashing] [#2122](https://github.com/cosmos/cosmos-sdk/pull/2122) - Implement slashing period * [types] \#2119 Parsed error messages and ABCI log errors to make them more human readable. * [simulation] Rename TestAndRunTx to Operation [#2153](https://github.com/cosmos/cosmos-sdk/pull/2153) + * [baseapp] Remove `SetTxDecoder` in favor of requiring the decoder be set in baseapp initialization. [#1441](https://github.com/cosmos/cosmos-sdk/issues/1441) * Tendermint diff --git a/baseapp/setters.go b/baseapp/setters.go index a8b1591a738a..28782c96dec6 100644 --- a/baseapp/setters.go +++ b/baseapp/setters.go @@ -26,12 +26,6 @@ func (app *BaseApp) SetCMS(cms store.CommitMultiStore) { } app.cms = cms } -func (app *BaseApp) SetTxDecoder(txDecoder sdk.TxDecoder) { - if app.sealed { - panic("SetTxDecoder() on sealed BaseApp") - } - app.txDecoder = txDecoder -} func (app *BaseApp) SetInitChainer(initChainer sdk.InitChainer) { if app.sealed { panic("SetInitChainer() on sealed BaseApp")