Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyring custom path is not supported #10818

Closed
4 tasks
tac0turtle opened this issue Dec 20, 2021 · 7 comments · Fixed by #12576
Closed
4 tasks

keyring custom path is not supported #10818

tac0turtle opened this issue Dec 20, 2021 · 7 comments · Fixed by #12576

Comments

@tac0turtle
Copy link
Member

Summary of Bug

custom paths are not supported anymore in the keyring due to new Mac restrictions. keybase/go-keychain#76.

Keyring needs to be updated, but we are unable to do so.

Version

master and everything else.

❯ go get github.com/keybase/go-keychain                                            
go: downloading github.com/keybase/go-keychain v0.0.0-20211119201326-e02f34051621
go get: upgraded github.com/keybase/go-keychain v0.0.0-20190712205309-48d3d31d256d => v0.0.0-20211119201326-e02f34051621

❯ make build
Makefile:71: RocksDB support is disabled; to build and test with RocksDB support, set ENABLE_ROCKSDB=true
go build -mod=readonly -tags "netgo ledger" -ldflags '-X github.com/cosmos/cosmos-sdk/version.Name=sim -X github.com/cosmos/cosmos-sdk/version.AppName=simd -X github.com/cosmos/cosmos-sdk/version.Version=0.43.0-beta1-629-g70885b33df -X github.com/cosmos/cosmos-sdk/version.Commit=70885b33df299f9ece38a995a2693c45fcfe3459 -X "github.com/cosmos/cosmos-sdk/version.BuildTags=netgo,ledger" -X github.com/tendermint/tendermint/version.TMCoreSemVer=v0.35.0 -w -s' -trimpath -o /Users/markobaricevic/code/CoTend/cosmos-sdk/build/ ./...
# github.com/zondax/hid
In file included from ../../../go/pkg/mod/github.com/zondax/[email protected]/hid_enabled.go:38:
../../../go/pkg/mod/github.com/zondax/[email protected]/hidapi/mac/hid.c:693:34: warning: 'kIOMasterPortDefault' is deprecated: first deprecated in macOS 12.0 [-Wdeprecated-declarations]
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/IOKit.framework/Headers/IOKitLib.h:123:19: note: 'kIOMasterPortDefault' has been explicitly marked deprecated here
# github.com/99designs/keyring
../../../go/pkg/mod/github.com/cosmos/[email protected]/keychain.go:55:8: query.SetMatchSearchList undefined (type keychain.Item has no field or method SetMatchSearchList)
../../../go/pkg/mod/github.com/cosmos/[email protected]/keychain.go:55:28: undefined: keychain.NewWithPath
../../../go/pkg/mod/github.com/cosmos/[email protected]/keychain.go:115:34: undefined: keychain.Keychain
../../../go/pkg/mod/github.com/cosmos/[email protected]/keychain.go:124:12: queryItem.SetMatchSearchList undefined (type keychain.Item has no field or method SetMatchSearchList)
../../../go/pkg/mod/github.com/cosmos/[email protected]/keychain.go:136:8: kcItem.SetAccess undefined (type keychain.Item has no field or method SetAccess)
../../../go/pkg/mod/github.com/cosmos/[email protected]/keychain.go:146:9: undefined: keychain.Keychain
../../../go/pkg/mod/github.com/cosmos/[email protected]/keychain.go:166:9: kcItem.UseKeychain undefined (type keychain.Item has no field or method UseKeychain)
../../../go/pkg/mod/github.com/cosmos/[email protected]/keychain.go:181:9: kcItem.SetAccess undefined (type keychain.Item has no field or method SetAccess)
../../../go/pkg/mod/github.com/cosmos/[email protected]/keychain.go:181:21: undefined: keychain.Access
../../../go/pkg/mod/github.com/cosmos/[email protected]/keychain.go:267:36: undefined: keychain.Keychain
../../../go/pkg/mod/github.com/cosmos/[email protected]/keychain.go:181:21: too many errors

@alessio are you able to provide some guidance?


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@tac0turtle
Copy link
Member Author

this is the proposed solution replace github.com/keybase/go-keychain => github.com/99designs/go-keychain v0.0.0-20191008050251-8e49817e8af4 (99designs/keyring#94)

Im not sure what to do in this case cause our users are stuck with a old version of keyring.

@alessio
Copy link
Contributor

alessio commented Dec 21, 2021

this is the proposed solution replace github.com/keybase/go-keychain => github.com/99designs/go-keychain v0.0.0-20191008050251-8e49817e8af4 (99designs/keyring#94)

Im not sure what to do in this case cause our users are stuck with a old version of keyring.

Let's try with this workaround - we need to find a different long term solution though. I'm investigating.

@tac0turtle
Copy link
Member Author

thank you, for now we can leave as is but long term I agree

@Ikxyz
Copy link

Ikxyz commented Mar 7, 2022

is there a solution am having the same issue

@vvllxxdd
Copy link

Still facing the same issue, not fixed.

1 similar comment
@Zhangguiguang
Copy link

Still facing the same issue, not fixed.

@alexanderbez
Copy link
Contributor

AFAIU, there is working planned or currently being done, labelled Keystone, that is refactoring the entire Keyring architecture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants