Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/authz spec improvement: add pruning of expired grants feature details #11990

Closed
dalmirel opened this issue May 18, 2022 · 0 comments · Fixed by #14957
Closed

x/authz spec improvement: add pruning of expired grants feature details #11990

dalmirel opened this issue May 18, 2022 · 0 comments · Fixed by #14957
Assignees

Comments

@dalmirel
Copy link

Summary of Issue

During the specification and code inspection of authz module (as a part of the audit process that includes model-based testing) I have found that specification markdown files are missing important information (in my opinion) about pruning of expired grants' logic in Begin Blocker function.
It was agreed with @AmauryM to open an issue for a suggestion to add additional details, in order to eliminate the need for seeking feature explanations in code implementation.

Since the pruning is mentioned here:

"We are maintaining a queue for authz pruning, whenever a grant created an item will be added to GrantQueue with a key of granter, grantee, expiration and value added as array of msg type urls."

maybe this is the best place(?).

Version

master (commit: 0b810ba)

auditing is performed for tag: v0.46.0-alpha4 (commit: 354faa8)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants