Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gas-related parameters to client config #12722

Closed
larry0x opened this issue Jul 26, 2022 · 2 comments
Closed

add gas-related parameters to client config #12722

larry0x opened this issue Jul 26, 2022 · 2 comments

Comments

@larry0x
Copy link
Contributor

larry0x commented Jul 26, 2022

Summary

gas-related parameters, namely gas, gas-adjustment, and gas-prices, should be configurable in client.toml, so that users don't need to type related flags every time they submit a tx via CLI.

see also: https://twitter.com/larry0x/status/1551761005755174912

Problem Definition

currently i have to type --gas auto --gas-adjustment 1.4 --gas-prices 0uosmo every time i submit a tx, which sucks

Proposal

#12723

@alexanderbez
Copy link
Contributor

alexanderbez commented Jul 26, 2022

Yes, I see the point in improved UX. But there is a counter to this. A user submits a tx with gas set in their config.toml and it's not correct or a bad value, then if they forget they could end up spending hours debugging. The point I'm raising here is these are the types of values you want to be extra careful about when submitting a tx, so it's best to be explicit.

I can see both sides of the argument here...

@julienrbrt
Copy link
Member

julienrbrt commented Oct 1, 2024

We've allowed to extend client.toml with default values: https://github.com/cosmos/cosmos-sdk/blob/v0.52.0-beta.1/simapp/simd/cmd/config.go#L28-L69 in 0.52 (ref #17513)

Additionally, viper will now properly bind all config value,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants