Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIGN_MODE_TEXTUAL Manual Testing #14975

Closed
8 of 9 tasks
Tracked by #11970
amaury1093 opened this issue Feb 9, 2023 · 1 comment
Closed
8 of 9 tasks
Tracked by #11970

SIGN_MODE_TEXTUAL Manual Testing #14975

amaury1093 opened this issue Feb 9, 2023 · 1 comment
Assignees

Comments

@amaury1093
Copy link
Contributor

amaury1093 commented Feb 9, 2023

Summary

Perform manual tests with a real Ledger device.

Problem

SIGN_MODE_TEXTUAL's implementation is almost finished, so we are entering the QA phase.

An external audit is happening for Textual (see #11970). After discussing internally, we decided to not wait for the external audit final report to submit a PR to the LedgerHQ repo.

This issue tracks the final manual testing to be done before we submit the app to Ledger.

Manual Tests

Testing on the main branch won't work, as there are some switches that are turned off for Textual. See this diff on how to turn on Textual.

Note: maybe interesting to compare number of screens of amino vs textual on the same tx.

Name date tester & device simd command comments #screens (non-expert) #screens amino video
MsgDelegate, MsgSend, MsgCreateValidtor 14.03.2023 @AmauryM Nano S Tested the new struct sign doc, tested dynamicpb
MsgDelegate 22.02.2023 @AmauryM Nano S simd tx staking delegate --from nanos <oper_addr> 10stake Fixed the MsgDelegate bug from 14.02 14 11
With fees and (unicode) memo 14.02.2023 @AmauryM Nano S simd tx bank send --fees 1stake --memo "💪" Both memo and fees are shown 14 12
MsgSubmitProposal too big payload 14.02.2023 @AmauryM Nano S 200kb proposal json Error: hidapi: unknown failure in the CLI
MsgSubmitProposal with special chars 14.02.2023 @AmauryM Nano S Proposal: {"title": "A 🚗 ","summary": "B\n @"} (trailing whitespaces, trailing @, unicodes) All good. 13 12 video
MsgDelegate 14.02.2023 @AmauryM Nano S simd tx staking delegate --from nanos <oper_addr> 10stake There's one screen with Message (2/2) [1/2]Message (1/1) [1/2] (with last 3 chars truncated), which is confusing 14 11 video
MsgSend 14.02.2023 @AmauryM Nano S simd tx bank send nanos <addr> 10stake Verified that the tx can be broadcasted and included in a block (passes antehandlers) on a local node. 12 11
MsgMultiSend 14.02.2023 @AmauryM Nano S simd tx bank multi-send nanos <addr1> <addr2> 10stake Confusion between Outputs (2/2) and Address [2/2]? 22 doesn't work
Expert Mode 31.01.2023 @AmauryM Nano S msg send Verified all screens are shown (address, gas, hash, pubkey) video
Nested Authz MsgExec 31.01.2023 @AmauryM Nano S simd tx authz exec tx.json --sign-mode textual with a tx.json containing a MsgSend Verified that 1. > for indentation are correctly shown and 2. Long field names are shown in the content part, not the title part video

TODO:

  • Basic MsgSend
  • Basic MsgDelegate
  • Nested Authz MsgExec
  • Unicode characters
  • Long field names
  • TX payload that is too large
  • Multi-signer tx
  • All screens are shown in expert mode
  • Amino still works
@amaury1093 amaury1093 changed the title Manual Testing SIGN_MODE_TEXTUAL Manual Testing Feb 9, 2023
@amaury1093
Copy link
Contributor Author

Closing. @facundomedica and I tested the latest ledger app, along with #15282 and #15302.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants