Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client: Refactor CoreContext #1551

Closed
ebuchman opened this issue Jul 4, 2018 · 1 comment · Fixed by #1741
Closed

Client: Refactor CoreContext #1551

ebuchman opened this issue Jul 4, 2018 · 1 comment · Fixed by #1741
Assignees
Labels

Comments

@ebuchman
Copy link
Member

ebuchman commented Jul 4, 2018

CoreContext is a little bit of a grab-bag of fields. We should change it to TxContext so it only has fields for signing a tx, ideally only fields that all txs use. Actually, in so far as it builds a StdTx, it might belong in x/auth/client. We can have a separate context for making queries, or maybe just pass in the couple of params as needed, but the TrustNode and Height fields don't belong with the rest of them.

We should also split up SignAndBuild into two separate functions since we intend to support the ability for LCD users to just build the tx, and sign it somewhere else. This should also help inform the CoreContext breakup and the building of better abstractions in the client package.

This is in some sense a follow up of #1157, as some of the improvements discussed there have been merged, but we can keep going

@alexanderbez
Copy link
Contributor

I'll pick this up @ebuchman 👍

@alexanderbez alexanderbez self-assigned this Jul 4, 2018
@alexanderbez alexanderbez changed the title client: change CoreContext to TxContext and remove non-tx related fields Client: Refactor CoreContext Jul 16, 2018
@ValarDragon ValarDragon mentioned this issue Jul 19, 2018
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants