Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ready-for-review: Query the votes on a proposal #1773

Merged
merged 4 commits into from
Jul 20, 2018
Merged

ready-for-review: Query the votes on a proposal #1773

merged 4 commits into from
Jul 20, 2018

Conversation

sunnya97
Copy link
Member

@sunnya97 sunnya97 commented Jul 19, 2018 •
edited by cwgoes
Loading

  • Updated all relevant documentation (docs/)
  • Updated all relevant code comments
  • Wrote tests
  • Updated CHANGELOG.md
  • Updated cmd/gaia and examples/

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jul 19, 2018 •
edited
Loading

Codecov Report

Merging #1773 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1773   +/-   ##
========================================
  Coverage    64.16%   64.16%           
========================================
  Files          115      115           
  Lines         6837     6837           
========================================
  Hits          4387     4387           
  Misses        2196     2196           
  Partials       254      254

@cwgoes
Copy link
Contributor

cwgoes commented Jul 19, 2018

Run make update_dev_deps to get the new dep version.

cwgoes
cwgoes approved these changes Jul 19, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cwgoes cwgoes merged commit f3a1290 into develop Jul 20, 2018
@cwgoes cwgoes deleted the sunny/query-votes-on-proposal branch July 20, 2018 00:02
@cwgoes cwgoes mentioned this pull request Jul 25, 2018
Closed
@snyk-bot snyk-bot mentioned this pull request Dec 23, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Feb 9, 2022
Open
@Itchibon777 Itchibon777 mentioned this pull request Jan 1, 2024
Open
@Itchibon777 Itchibon777 mentioned this pull request Mar 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunnya97 @cwgoes