Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update RequestExtendVote #17992

Closed
1 task done
samricotta opened this issue Oct 6, 2023 · 1 comment · Fixed by #17993
Closed
1 task done

chore: Update RequestExtendVote #17992

samricotta opened this issue Oct 6, 2023 · 1 comment · Fixed by #17993
Assignees

Comments

@samricotta
Copy link
Contributor

samricotta commented Oct 6, 2023

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

RequestExtendVote was requested to be updated from the comet team, there needs to be a few fields added. Sergio had spoken to Marko but should be fixed for 0.50 release

message RequestExtendVote {
// the hash of the block that this vote may be referring to
bytes hash = 1;
// the height of the extended vote
int64 height = 2;

Should be

message RequestExtendVote {
  // the hash of the block that this vote may be referring to
  bytes hash = 1;
  // the height of the extended vote
  int64 height = 2;
  // info of the block that this vote may be referring to
  google.protobuf.Timestamp time                 = 3 [(gogoproto.nullable) = false, (gogoproto.stdtime) = true];
  repeated bytes            txs                  = 4;
  CommitInfo                proposed_last_commit = 5 [(gogoproto.nullable) = false];
  repeated Misbehavior      misbehavior          = 6 [(gogoproto.nullable) = false];
  bytes                     next_validators_hash = 7;
  // address of the public key of the original proposer of the block.
  bytes proposer_address = 8;
}

Cosmos SDK Version

0.50

How to reproduce?

No response

@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Oct 6, 2023
@samricotta samricotta changed the title chore: chore: Update RequestExtendVote Oct 6, 2023
@julienrbrt
Copy link
Member

julienrbrt commented Oct 6, 2023

It is probably because we haven't updated tendermint protos in a while:

CMT_URL = https://raw.githubusercontent.com/cometbft/cometbft/v0.38.0-alpha.2/proto/tendermint

make proto-update-deps && make proto-gen should be sufficient once we bump the above to final 0.38.

@julienrbrt julienrbrt added Type: Build and removed needs-triage Issue that needs to be triaged labels Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants