R4R: Fedekunze/1939 tests for staking lcd #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedekunze
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
added 2 commits
August 13, 2018 14:52
…edekunze/1939-tests-for-staking-lcd Rebase develop
Codecov Report
@@ Coverage Diff @@
## develop #2000 +/- ##
========================================
Coverage 64.86% 64.86%
========================================
Files 115 115
Lines 6862 6862
========================================
Hits 4451 4451
Misses 2127 2127
Partials 284 284 |
alexanderbez
suggested changes
Aug 13, 2018
There was a problem hiding this comment.
Thanks @fedekunze ! I left a few minor remarks, but otherwise LGTM 👍
client/lcd/lcd_test.go
Outdated
| @@ -409,40 +410,69 @@ func TestBonding(t *testing.T) { | |||
| bond := getDelegation(t, port, addr, validator1Owner) | |||
| require.Equal(t, "60.0000000000", bond.Shares) | |||
|
|
|||
| // query summary | |||
| summary := getDelegationSummary(t, port, addr) | |||
| assert.Len(t, summary.Delegations, 1, "Delegation summary holds all delegations") | |||
There was a problem hiding this comment.
The convention is we use require's I believe 👍
client/lcd/lcd_test.go
Outdated
| // check if tx was committed | ||
| require.Equal(t, uint32(0), resultTx.CheckTx.Code) | ||
| require.Equal(t, uint32(0), resultTx.DeliverTx.Code) | ||
|
|
||
| // // query validator |
There was a problem hiding this comment.
Let's remove any unnecessary commented out code.
client/lcd/lcd_test.go
Outdated
| assert.Len(t, unbondings, 1, "Unbondings holds all unbonding-delegations") | ||
| assert.Equal(t, "30", unbondings[0].Balance.Amount.String()) | ||
| assert.Equal(t, "60", unbondings[0].Balance.Amount.String()) |
client/lcd/lcd_test.go
Outdated
| bondedValidators = getDelegatorValidators(t, port, addr) | ||
| require.Len(t, bondedValidators, 0) | ||
|
|
||
| // resultTx = doBeginUnbonding(t, port, seed, name, password, addr, validator1Owner) |
client/lcd/lcd_test.go
Outdated
| var bondedValidators []stake.BechValidator | ||
| err := cdc.UnmarshalJSON([]byte(body), &bondedValidators) | ||
| require.Nil(t, err) | ||
| fmt.Println(fmt.Sprintf("–––> DelegatorVals: %v", bondedValidators)) |
There was a problem hiding this comment.
Do we need these print statements?
client/lcd/lcd_test.go
Outdated
| func doDelegate(t *testing.T, port, seed, name, password string, delegatorAddr, validatorAddr sdk.AccAddress) (resultTx ctypes.ResultBroadcastTxCommit) { | ||
| func getDelegatorValidators(t *testing.T, port string, delegatorAddr sdk.AccAddress) []stake.BechValidator { | ||
|
|
||
| var res *http.Response |
There was a problem hiding this comment.
Could we improve the spacing a bit to help the legibility?
client/lcd/lcd_test.go
Outdated
|
|
||
| func getDelegatorValidator(t *testing.T, port string, delegatorAddr sdk.AccAddress, validatorAddr sdk.AccAddress) stake.BechValidator { | ||
|
|
||
| var res *http.Response |
x/stake/client/rest/query.go
Outdated
| @@ -32,6 +32,18 @@ func registerQueryRoutes(cliCtx context.CLIContext, r *mux.Router, cdc *wire.Cod | |||
| delegatorTxsHandlerFn(cliCtx, cdc), | |||
| ).Methods("GET") | |||
|
|
|||
| // GET /stake/delegators/{delegatorAddr}/validators // Query all validators that a delegator is bonded to | |||
There was a problem hiding this comment.
Do we actually need the comments // GET /stake/delegators/{delegatorAddr}/validators/{validatorAddr} and the other? It seems the code documents that enough? The other comments are good 👍
added 2 commits
August 13, 2018 16:58
|
@alexanderbez Addressed comments ! |
alexanderbez
approved these changes
Aug 13, 2018
rigelrozanski
approved these changes
Aug 13, 2018
fedekunze
added a commit
that referenced
this pull request
Aug 15, 2018
* Added tests for Delegator Validators routes * Updated tests for undelegations * Updated Gaia-lite docs * Updated PENDING.md * Updated comments * Deleted more comments * Add spacing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1939
Staking endpoints now support:
GET /stake/delegators/{delegatorAddr}/validatorsGET /stake/delegators/{delegatorAddr}/validators/{validatorAddr}Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Updated all relevant documentation (
docs/)Updated all relevant code comments
Wrote tests
Added entries in
PENDING.mdthat include links to the relevant issue or PR that most accurately describes the change.Updated
cmd/gaiaandexamples/For Admin Use: