Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Update to Tendermint 0.24 (except NextValSet offsets) #2219

Merged
merged 29 commits into from
Oct 3, 2018

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Sep 3, 2018

Currently against TM v0.24.0-rc0 tag, will be updated to pull TM release once released.

This does not have the slashing NextValSet offsets, those will happen in a separate PR for ease of review.

Closes #2133

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@ValarDragon ValarDragon mentioned this pull request Sep 4, 2018
5 tasks
@cwgoes cwgoes changed the title WIP: Update to Tendermint 0.24 R4R: Update to Tendermint 0.24 Sep 6, 2018
@cwgoes cwgoes changed the title R4R: Update to Tendermint 0.24 R4R: Update to Tendermint 0.24 (except NextValSet offsets) Sep 6, 2018
@cwgoes cwgoes added the T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). label Sep 6, 2018
@cwgoes
Copy link
Contributor Author

cwgoes commented Sep 7, 2018

Looks like the Tendermint Verifier uses the same LevelDB somehow, and that's causing a conflict?

@rigelrozanski
Copy link
Contributor

test cover failing

@cwgoes
Copy link
Contributor Author

cwgoes commented Sep 18, 2018

This is blocked on tendermint/tendermint#2396.

@alexanderbez
Copy link
Contributor

@cwgoes this is needed for the next release/game of steaks, correct?

@cwgoes
Copy link
Contributor Author

cwgoes commented Sep 26, 2018

@cwgoes this is needed for the next release/game of steaks, correct?

Yes. Still blocked on tendermint/tendermint#2396.

@cwgoes
Copy link
Contributor Author

cwgoes commented Sep 26, 2018

Rebased & fixed conflicts, this can be merged before tendermint/tendermint#2396, need to fix a testcase first.

@cwgoes
Copy link
Contributor Author

cwgoes commented Sep 27, 2018

The LCD tests are now failing because of a Gaia Lite validator set mismatch:

?   	github.com/cosmos/cosmos-sdk/client/keys	[no test files]
E[09-27|12:44:00.676] Couldn't connect to any seeds                module=p2p 
LADDR tcp://0.0.0.0:42277
REQUEST GET http://localhost:44681/keys/seed
REQUEST POST http://localhost:44681/keys
REQUEST GET http://localhost:44681/keys
REQUEST GET http://localhost:44681/keys/test_newname
REQUEST PUT http://localhost:44681/keys/test_newname
REQUEST PUT http://localhost:44681/keys/test_newname
REQUEST DELETE http://localhost:44681/keys/test_newname
E[09-27|12:44:01.876] Couldn't connect to any seeds                module=p2p 
LADDR tcp://0.0.0.0:41577
REQUEST GET http://localhost:45739/version
REQUEST GET http://localhost:45739/node_version
LADDR tcp://0.0.0.0:37209
E[09-27|12:44:02.330] Couldn't connect to any seeds                module=p2p 
REQUEST GET http://localhost:35123/node_info
REQUEST GET http://localhost:35123/syncing
E[09-27|12:44:02.762] Failed to save AddrBook to file              module=p2p book=/home/cwgoes/.tendermint_test/_home_cwgoes_working_go_src_github.com_cosmos_cosmos-sdk_client_lcd/config/addrbook.json file=/home/cwgoes/.tendermint_test/_home_cwgoes_working_go_src_github.com_cosmos_cosmos-sdk_client_lcd/config/addrbook.json err=rename /home/cwgoes/.tendermint_test/_home_cwgoes_working_go_src_github.com_cosmos_cosmos-sdk_client_lcd/config/write-file-atomic-7131397554344445057 /home/cwgoes/.tendermint_test/_home_cwgoes_working_go_src_github.com_cosmos_cosmos-sdk_client_lcd/config/addrbook.json: no such file or directory
LADDR tcp://0.0.0.0:36681
E[09-27|12:44:02.774] Couldn't connect to any seeds                module=p2p 
REQUEST GET http://localhost:37305/blocks/latest
REQUEST GET http://localhost:37305/blocks/2
--- FAIL: TestBlock (4.71s)
	Error Trace:	lcd_test.go:189
	Error:      	Not equal: 
	            	expected: 200
	            	actual  : 500
	Test:       	TestBlock
	Messages:   	Error{Validator set is different. Got FD73042AAB7F18B7F549FAC832949C79ECFBBE38 want 19351102A125505A3388272570E86FD3501C437A}
LADDR tcp://0.0.0.0:37343
E[09-27|12:44:07.491] Couldn't connect to any seeds                module=p2p 
REQUEST GET http://localhost:33413/validatorsets/latest
REQUEST GET http://localhost:33413/validatorsets/2
--- FAIL: TestValidators (0.66s)
	Error Trace:	lcd_test.go:222
	Error:      	Not equal: 
	            	expected: 200
	            	actual  : 500
	Test:       	TestValidators
	Messages:   	Error{Validator set is different. Got FD73042AAB7F18B7F549FAC832949C79ECFBBE38 want 19351102A125505A3388272570E86FD3501C437A}
E[09-27|12:44:08.220] Couldn't connect to any seeds                module=p2p 
LADDR tcp://0.0.0.0:45327
REQUEST GET http://localhost:41457/accounts/cosmos137n2k4addpc0dddju4mntuu09ucww09kq2ausg
REQUEST GET http://localhost:41457/accounts/cosmos1gsqdukpdyh7ymx5e0pjpum9hgz895mqnegq44m
REQUEST GET http://localhost:41457/accounts/cosmos1gsqdukpdyh7ymx5e0pjpum9hgz895mqnegq44m

@cwgoes cwgoes force-pushed the cwgoes/update-tendermint-upstream branch from f2ab4a3 to fd36abf Compare September 27, 2018 10:46
@alexanderbez
Copy link
Contributor

@cwgoes do you have an inclination as to why this is happening?

@cwgoes
Copy link
Contributor Author

cwgoes commented Oct 2, 2018

@alexanderbez Yes, it's an upstream Tendermint issue, I believe @jaekwon was debugging it.

@cwgoes
Copy link
Contributor Author

cwgoes commented Oct 2, 2018

Let's disable the test for now but try to fix the underlying issue before 0.25.

@cwgoes
Copy link
Contributor Author

cwgoes commented Oct 3, 2018

Let's disable the test for now but try to fix the underlying issue before 0.25.

So updated, and left a TODO to set trustNode to false again later.

@cwgoes cwgoes merged commit 1798346 into develop Oct 3, 2018
@cwgoes cwgoes deleted the cwgoes/update-tendermint-upstream branch October 3, 2018 15:58
chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: comet T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants