Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do you think about opening port for prometheus on cosmos-sdk? #2426

Closed
4 tasks
Thunnini opened this issue Oct 2, 2018 · 2 comments
Closed
4 tasks

How do you think about opening port for prometheus on cosmos-sdk? #2426

Thunnini opened this issue Oct 2, 2018 · 2 comments

Comments

@Thunnini
Copy link
Contributor

Thunnini commented Oct 2, 2018

Summary

Open port for prometheus metrics.

Problem Definition

https://github.com/Thunnini/cosmos-sdk/tree/add-metrics
I am trying to support metrics on cosmos-sdk. It seemed that prometheus-go-client saves metrics data only in ram. So if cosmos-sdk runs with tendermint at same process, they can share prometheus metrics data, so no need to open additional port... But, if cosmos-sdk runs on standalone mode, prometheus metrics data can't be shared, so Cosmos-sdk should open another prometheus server. In my opinion, it is better to open a new port in both cases to support with same way... What do you think about this approach?

Proposal

Add variables in config file about which port to open for prometheus in cosmos-sdk.
Open another prometheus server for cosmos-sdk.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@Thunnini Thunnini changed the title How do you think about opening port for prometheus on cosmos-sdk? #2169 How do you think about opening port for prometheus on cosmos-sdk? Oct 2, 2018
@Thunnini
Copy link
Contributor Author

Thunnini commented Oct 2, 2018

related #2169

@jackzampolin
Copy link
Member

@Thunnini You should be able to register your metrics handlers on the instance of the Prometheus object stored on the Tendermint node. There are more details in the above issue. Closing this in favor of #2169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants