Staking store keys bug fix + memory improvement #2435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done by removing repeated appends, which will create a new slice if theres insufficient capacity, and instead creating a key of the correct size, and then copying the data into it.
ValarDragon
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
ValarDragon
added
ready-for-review
T: API Breaking
Codecov Report
@@ Coverage Diff @@
## develop #2435 +/- ##
==========================================
Coverage ? 61.18%
==========================================
Files ? 123
Lines ? 7396
Branches ? 0
==========================================
Hits ? 4525
Misses ? 2558
Partials ? 313 |
alexanderbez
approved these changes
Oct 4, 2018
| var ( | ||
| pk1 = ed25519.GenPrivKey().PubKey() | ||
| ) | ||
|
|
There was a problem hiding this comment.
Do we have unit tests for GetREDByValSrcIndexKey and GetREDByValDstIndexKey? Otherwise, this LGTM. Thanks 👍
There was a problem hiding this comment.
We don't have any to my knowledge. I can make some
There was a problem hiding this comment.
Let's do that, but it can be in a separate PR.
cwgoes
approved these changes
Oct 4, 2018
| var ( | ||
| pk1 = ed25519.GenPrivKey().PubKey() | ||
| ) | ||
|
|
There was a problem hiding this comment.
Let's do that, but it can be in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves memory efficiency of getting store keys
This is done by removing repeated appends, which will create a new
slice if theres insufficient capacity, and instead creating a key
of the correct size, and then copying the data into it.
This PR also Removes empty bytes from ValidatorPowerRank store key
Closes #2433
Please do not squash, and review commit by commit.
docs/) - n/a?PENDING.mdwith issue #Files changedin the github PR explorerFor Admin Use: