Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulation no longer simulating governance proposals correctly #2733

Closed
cwgoes opened this issue Nov 8, 2018 · 3 comments
Closed

Simulation no longer simulating governance proposals correctly #2733

cwgoes opened this issue Nov 8, 2018 · 3 comments

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Nov 8, 2018

e.g. with make test_sim_gaia_fast:

                             endblock/validatorupdates/updated => 1263
                                          gov/MsgDeposit/false => 3532
                                   gov/MsgSubmitProposal/false => 174
                                      slashing/MsgUnjail/false => 2986

This means a large range of state space is unexplored. Likely we changed something which caused this.

@jaekwon
Copy link
Contributor

jaekwon commented Nov 12, 2018

Not sure what's going on here... make test_sim_gaia_fast on develop for me shows a lot more than that.

@cwgoes
Copy link
Contributor Author

cwgoes commented Nov 12, 2018

Not sure what's going on here... make test_sim_gaia_fast on develop for me shows a lot more than that.

Does it show successful proposals (e.g. gov/MsgSubmitProposal/true) ?

@cwgoes
Copy link
Contributor Author

cwgoes commented Nov 12, 2018

Ah it was just a minor mistake in a sim refactor. Fixed in #2748 but we need to check that gov import/export works now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants