Disable Withdraw-Addresses in the pre-send era of cosmos

[rigelrozanski]

.ValarDragon [1:38 AM]
I just noticed that there is a MsgModifyWithdrawAddress in fee distribution, doesn't this essentially let you sell bonded stake rewards? Is that intentional? (edited)

Its not technically getting around unbonding periods, but it kinda feels like its in that same spirit

rige [1:43 AM]
I’m not sure that is let’s you “sell” more like “give-away” - which actually could be a problem pre-send enabling depending on how rigid we want to make it - we should open up a prelaunch issue about this. In the existing mechanism you’re correct in saying that it does not get around unbonding periods - it’s doesn’t actually have anything to do with this as fees which have been paid are always unbonded, and this WithdrawAddress only applies to rewards and not to bonded atoms.

[cwgoes]

Hehe, I had re-implemented this in F1 (#3099), shall I un-re-implement it? Doesn't seem too necessary to have this feature in general honestly (could easily withdraw-then-send in a multi-Msg); we can definitely remove it pre-launch / pre-transfers.

[rigelrozanski]

Rather than remove it why don't we disable it with a global parameter?

[cwgoes]

Let's do that; but in a separate PR for ease of review (F1 has enough as-is).