Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More efficient round-up quotients #3812

Closed
cwgoes opened this issue Mar 6, 2019 · 3 comments
Closed

More efficient round-up quotients #3812

cwgoes opened this issue Mar 6, 2019 · 3 comments
Labels
T: Performance Performance improvements

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Mar 6, 2019

Ref https://github.com/cosmos/cosmos-sdk/pull/3750/files#r261452457

@cwgoes cwgoes added core T: Performance Performance improvements labels Mar 6, 2019
@cwgoes cwgoes changed the title More effecient round-up quotients More efficient round-up quotients Mar 6, 2019
@alexanderbez alexanderbez removed the core label Jul 6, 2020
@elias-orijtech
Copy link
Contributor

Hi! Is this issue still relevant?

@ValarDragon
Copy link
Contributor

Its technically still relevant, but I wouldn't consider it a good use of optimization effort for the following two reasons:

  • The method is rarely used
  • We'd have to be very careful to ensure its state machine compatible

I think something that would be of higher impact is looking into if theres any way to make dec.Unmarshal() faster, as this dominates lots of protobuf deserialization times.

@elias-orijtech
Copy link
Contributor

Alright, I'll close this as not worth the effort.

@elias-orijtech elias-orijtech closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: Performance Performance improvements
Projects
None yet
Development

No branches or pull requests

4 participants