allow underscores or other separators in coin denominations in CLI

[kevlubkcm]

Summary

Since the base unit is micro-atom, we frequently need to type very large numbers into the CLI which is error prone. Allowing separators will make this easier (a la PEP 515)

Think this is really only necessary in the raw gaiacli interface; could be as simple as as strreplace('_', '') in the argument parser

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[alexanderbez]

Thing is we cannot use , as a separator because this is used to separate coins. Otherwise, we can do this in ParseCoin/s.

[kevlubkcm]

I see. then how about _ like 1_000_000?

[alexanderbez]

We can really use whatever we want really, as in ParseCoin will just strip everything that is not a digit.

[rigelrozanski]

Wait is this already resolved?

[alexanderbez]

I believe from convos I had w/ @jaekwon, we only want to support , and ; (in rare circumstances).

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[tac0turtle]

_ seems useful for UX in the cli and possibly elsewhere.

[odeke-em]

Now that Go has since 2019 supported underscores in Go1.13, strconv.ParseInt https://pkg.go.dev/strconv#ParseInt and also after @aaronc's PR #9699 which permitted _ in coin denominations in July 2021
per https://github.com/cosmos/cosmos-sdk/blame/bafe5040f22c55f5053b34bc0d8095b566022f20/types/coin.go#L831 or

cosmos-sdk/types/coin.go

Line 831 in bafe504

reDnmString = `[a-zA-Z][a-zA-Z0-9/:._-]{2,127}`

I think that this issue can now be closed. Kindly pinging @elias-orijtech, could you help quarterback the closing and any related changes for this issue? Thank you