Refactor crisis package using internal #4649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
alessio
requested review from
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
|
Will add a pending entry once review is passed |
alexanderbez
suggested changes
Jul 1, 2019
Codecov Report
@@ Coverage Diff @@
## master #4649 +/- ##
==========================================
+ Coverage 54.97% 54.98% +<.01%
==========================================
Files 272 271 -1
Lines 17027 17021 -6
==========================================
- Hits 9361 9359 -2
+ Misses 6980 6976 -4
Partials 686 686 |
fedekunze
approved these changes
Jul 1, 2019
alexanderbez
suggested changes
Jul 1, 2019
x/crisis/internal/keeper/keeper.go
Outdated
| // FeeCollectorName returns the name of the FeeCollector module. | ||
| func (k Keeper) FeeCollectorName() string { return k.feeCollectorName } | ||
|
|
||
| func (k Keeper) SendCoinsFromAccountToModule(ctx sdk.Context, senderAddr sdk.AccAddress, recipientModule string, amt sdk.Coins) sdk.Error { |
There was a problem hiding this comment.
The only valid execution of this is to send from an account to k.FeeCollectorName() only. So I'm thinking we change this to:
func (k Keeper) SendCoinsFromAccountToModule(ctx sdk.Context, senderAddr sdk.AccAddress, amt sdk.Coins) sdk.Error {
return k.supplyKeeper.SendCoinsFromAccountToModule(ctx, senderAddr, k.feeCollectorName, amt)
}
x/crisis/internal/keeper/keeper.go
Outdated
| func (k Keeper) InvCheckPeriod() uint { return k.invCheckPeriod } | ||
|
|
||
| // FeeCollectorName returns the name of the FeeCollector module. | ||
| func (k Keeper) FeeCollectorName() string { return k.feeCollectorName } |
There was a problem hiding this comment.
We may not even need this. See below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #4597
docs/)clog add [section] [stanza] [message]Files changedin the github PR explorerFor Admin Use: