-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICS03: Connection versioning for Handshake #5079
Comments
@mossid What is the status of this? |
The function just needs to be updated to increase it’s performance + add tests. |
Is this still applicable? Seems like a small task. |
This should be tested in conjunction with dynamic IBC, e.g. with CosmWASM, cc @ethanfrey. |
Is version: Since this is done on a |
Ah yes, you are completely correct - this particular issue is for connection-level versioning, but we should also ensure that our implementation of channel-level versioning is up to snuff - #5846. |
Specifically, what we probably want is:
Then both chains agree on version string ~ featureset. Also, we should
|
should an error be returned in |
Yes. |
getCompatibleVersion
andpickVersion
are defined underVersioning
in ICS03. The current implementation includes version information in the datagram but lacks version negotiation. Both functions need to be implemented as a hardcoded function and called by the handshake functions.TODO:
The text was updated successfully, but these errors were encountered: