Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICS 26: Routing Module #5131

Closed
mossid opened this issue Oct 1, 2019 · 2 comments
Closed

ICS 26: Routing Module #5131

mossid opened this issue Oct 1, 2019 · 2 comments

Comments

@mossid
Copy link
Contributor

mossid commented Oct 1, 2019

Module callback interface in https://github.com/cosmos/ics/tree/master/spec/ics-026-routing-module is not implemented. Either

  1. Each Port struct should expose callback registry functions, or
  2. Port construction function should take list of functions, which will be exposed by AppModule of each modules
@mossid mossid added the x/ibc label Oct 1, 2019
@alexanderbez alexanderbez mentioned this issue Oct 1, 2019
Closed
30 tasks
@fedekunze
Copy link
Collaborator

Module callback interface in https://github.com/cosmos/ics/tree/master/spec/ics-026-routing-module is not implemented

Shouldn't we implement the whole x/routing module as well?

Either

  1. Each Port struct should expose callback registry functions, or
  2. Port construction function should take list of functions, which will be exposed by AppModule of each modules

I think 2. is cleaner

@fedekunze
Copy link
Collaborator

Replaced by #5333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mossid @fedekunze