Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement timeout timestamp #5836

Closed
cwgoes opened this issue Mar 19, 2020 · 2 comments · Fixed by #6022
Closed

Implement timeout timestamp #5836

cwgoes opened this issue Mar 19, 2020 · 2 comments · Fixed by #6022
Assignees

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Mar 19, 2020

Ref spec PR - cosmos/ibc#398

@cwgoes cwgoes added this to the IBC 1.0 milestone Mar 19, 2020
@colin-axner
Copy link
Contributor

I think I can tackle this issue if no one has begun.

Following the above reference, the timestamp in the ics spec is a unit64. Is there a reason the timestamp value isn't time.Time? time.Time is already used by tendermint and I think it would be appropriate usage in this situation.

@cwgoes
Copy link
Contributor Author

cwgoes commented Apr 17, 2020

@colin-axner That would be great! The timestamp value does need to be serialised in a uniform format usable cross-chain, so it can't depend on a Golang-specific time.Time type, but we could use a wrapper with time.Time as long as it gets serialised & deserialised to & from a uint64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants