Block results internal error with validator_updates

[tomtau]

Summary of Bug

block_results (legacy) json-rpc endpoint will return the following error:

{
  "jsonrpc": "2.0",
  "id": -1,
  "error": {
    "code": -32603,
    "message": "Internal error",
    "data": "error marshalling response: cannot encode unregistered type crypto.PublicKey_Ed25519"
  }
}

Version

04ff40a

Steps to Reproduce

1. start up a network
2. change voting power: e.g. trigger slashing (e.g. shut down one node and wait for missed_blocks_counter to go over the threshold network param) or delegate
3. call /block_results?height=<block height when voting power changed>

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[tomtau]

this may be applicable outside slashing to any module where validator_updates will be non-null in some blocks / block_results

[tomtau]

this may be applicable outside slashing to any module where validator_updates will be non-null in some blocks / block_results

just tried with "delegate" -- the same issue

[alexanderbez]

Probably because we're not using the correctly populated client.Context @amaurymartiny @sahith-narahari?

[amaury1093]

Hey @tomtau, I just tried this /block_results endpoint, and didn't get this error, even though I also saw PublicKey_Ed25519.

I created a test for this in #7442, would like to confirm with you if you're still seeing this.

[tomtau]

@amaurymartiny I'll try with the latest master.
For reference -- on the current Stargate testnet: http://ec2-18-188-71-91.us-east-2.compute.amazonaws.com:26657/block_results?height=177991

which runs against 27db2cf https://github.com/cosmos/gaia/blob/zaki/stargate-3/go.mod#L6

[tomtau]

@amaurymartiny I tried with 0047099
and still the same. Is there a difference how client.Context is populated in "... start" command and the network integration tests?

[tomtau]

one difference is that in that test, RPCClient is rpc/client/client.Local (instead of HTTP), so it's not doing any JSON marshalling / unmarshalling?

[amaury1093]

one difference is that in that test, RPCClient is rpc/client/client.Local (instead of HTTP), so it's not doing any JSON marshalling / unmarshalling?

Yes, thanks for the lead, that was it! However, the marshalling is handled by Tendermint (tmjson), so I believe a patch needs to be added on the tendermint repo. I pinged @marbar3778 about possible solutions in https://github.com/cosmos/cosmos-sdk/pull/7442/files#r499496017

[tac0turtle]

ah this is a bug in Tendermint. Will open a PR to fix it

[tac0turtle]

fix: tendermint/tendermint#5459