Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs]: Update server/README.md with alternative to simapp.MakeEncodingConfig() #7685

Closed
clevinson opened this issue Oct 26, 2020 · 2 comments · Fixed by #8250
Closed

[docs]: Update server/README.md with alternative to simapp.MakeEncodingConfig() #7685

clevinson opened this issue Oct 26, 2020 · 2 comments · Fixed by #8250
Assignees
Labels
T:Docs Changes and features related to documentation.

Comments

@clevinson
Copy link
Contributor

reference: see comment#7681 (comment).

In general, this sample code should be rewritten to not use EncodingConfig.

@clevinson clevinson added this to the v0.40 [Stargate] milestone Oct 26, 2020
@clevinson clevinson added T:Docs Changes and features related to documentation. backlog labels Oct 26, 2020
@amaury1093
Copy link
Contributor

For the time being, maybe a solution could be just a comment to tell users to implement their own EncodingConfig instead of using MakeTestEncodingConfig

@robert-zaremba
Copy link
Collaborator

robert-zaremba commented Jan 4, 2021

I think it's fine to use the MakeTestEncodingConfig. We just need to make sure that it's used only once. Basically, a user can use it ONLY:

  • in tests
  • when creating a new app

In all other places, users must use app.AppCodec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants