New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify SetNewParams() in x/stake #2149

Closed

mossid opened this issue Aug 25, 2018 · 2 comments

Labels

C:x/staking good first issue

Contributor

mossid commented Aug 25, 2018

SetNewParams() in x/stake sets all parameter from params struct. This will be used only for initializing all parameters in testing. We should define SetXXX()s for individual parameters and use it for production code.

Also see: #1772 conversation.

Contributor

ValarDragon commented Aug 25, 2018

If we have code like this for tests, lets make it visually obvious. e.g. instead of
SetNewParams, instead do TestingSetNewParams or SetNewParamsForTesting.

ValarDragon added good first issue C:x/staking API labels

Contributor

rigelrozanski commented Aug 27, 2018

The params should probably be moved to the global params store anyways - not sure that it will matter after then

jackzampolin closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment