Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

param migration (params module is deprecated in sdk0.47) #2214

Closed
10 tasks
Tracked by #2413
yaruwangway opened this issue Feb 16, 2023 · 2 comments
Closed
10 tasks
Tracked by #2413

param migration (params module is deprecated in sdk0.47) #2214

yaruwangway opened this issue Feb 16, 2023 · 2 comments
Assignees

Comments

@yaruwangway
Copy link
Contributor

yaruwangway commented Feb 16, 2023

Summary

Gaia v10 will use sdk 0.47.

In sdk0.47, params store is deprecated, in favour of each module housing its own parameters. All the params in params module need to be migrated. migration example
Besides, params holding in params module need to migrate to the sdk modules, params module also holds globalfees params, so globalfees params need to migrate to global fees module.

Problem Definition

Proposal

The following steps need to be done:

bank, gov, etc params migration

  • all the params in the params store need to be migrated, call the migration in upgrade handler. (if the params module is sdk module)

globalfee params migration

  • add set params in globalfee module, example
  • migrating the value from params store to globalfee store, example
  • change the fee antehandler to get data from globalfee store rather than params store, example.
  • call the migration in upgrade handler (version map)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
  • Is a spike necessary to map out how the issue should be approached?
@yaruwangway yaruwangway modified the milestones: Bump SDK to 0.47, Gaia v10.0.0 Feb 16, 2023
@yaruwangway yaruwangway self-assigned this Feb 23, 2023
@yaruwangway yaruwangway changed the title Gaia v10: param module, global fee module migration Gaia v10: param migration (params module is deprecated in sdk0.47) Feb 23, 2023
@yaruwangway yaruwangway modified the milestones: Gaia v10.0.0, Bump SDK to 0.47 Feb 23, 2023
@mpoke mpoke removed this from the Bump SDK to 0.47 milestone Mar 5, 2023
@mpoke mpoke changed the title Gaia v10: param migration (params module is deprecated in sdk0.47) param migration (params module is deprecated in sdk0.47) Mar 6, 2023
@mpoke
Copy link
Contributor

mpoke commented Sep 14, 2023

Closing as this work is tracked by #2540

@sainoe
Copy link
Contributor

sainoe commented Sep 26, 2023

Postponed to the SDKv50 upgrade which removes the x/params module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants