Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidy the bypas-min-fee-msg-types in config.toml #2368

Closed
5 tasks
sainoe opened this issue Apr 5, 2023 · 1 comment
Closed
5 tasks

tidy the bypas-min-fee-msg-types in config.toml #2368

sainoe opened this issue Apr 5, 2023 · 1 comment
Assignees
@yaruwangway
Labels
type: feature-request New feature or request improvement

Comments

@sainoe
Copy link
Contributor

sainoe commented Apr 5, 2023 •
edited
Loading

Summary

As part of the global min fee refactor, the BypassMinFeeMsgs and the MaxTotalBypassMinFeeMsgGasUsage are added to the params store and then should be removed from the config file.

Proposal

  • Remove BypassMinFeeMsgs and the MaxTotalBypassMinFeeMsgGasUsage from Gaia's config
  • Update tests

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
  • Is a spike necessary to map out how the issue should be approached?
@sainoe sainoe added type: feature-request New feature or request improvement status: waiting-triage This issue/PR has not yet been triaged by the team. labels Apr 5, 2023
@sainoe sainoe added this to the Gaia v10.0.0 milestone Apr 5, 2023
@sainoe sainoe self-assigned this Apr 5, 2023
@yaruwangway yaruwangway mentioned this issue Apr 5, 2023
Closed
@sainoe sainoe mentioned this issue Apr 5, 2023
Closed
18 tasks
@yaruwangway yaruwangway mentioned this issue Apr 5, 2023
Closed
@sainoe sainoe changed the title Feat: move bypass-min-fee-msg params to store Feat: tidy the bypas-min-fee-msg-types in config.toml Apr 5, 2023
@sainoe sainoe changed the title Feat: tidy the bypas-min-fee-msg-types in config.toml tidy the bypas-min-fee-msg-types in config.toml Apr 5, 2023
@mpoke mpoke removed the status: waiting-triage This issue/PR has not yet been triaged by the team. label Apr 12, 2023
@mpoke mpoke removed this from the Gaia v10.0.0 milestone Apr 14, 2023
@mpoke mpoke assigned yaruwangway and unassigned sainoe May 11, 2023
@sainoe
Copy link
Contributor Author

sainoe commented May 24, 2023

Solved in #2352

@sainoe sainoe closed this as completed May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yaruwangway yaruwangway

Labels
type: feature-request New feature or request improvement
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: tidy bypass-msg in config cosmos/gaia
3 participants
@mpoke @sainoe @yaruwangway