Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: e2e ibc test #2570

Closed
Tracked by #2406
yaruwangway opened this issue Jun 7, 2023 · 0 comments · Fixed by #2859
Closed
Tracked by #2406

refactor: e2e ibc test #2570

yaruwangway opened this issue Jun 7, 2023 · 0 comments · Fixed by #2859
Assignees
Labels
S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth scope: testing Code review, testing, making sure the code is following the specification.

Comments

@yaruwangway
Copy link
Contributor

yaruwangway commented Jun 7, 2023

Problem

In e2e test, there are three categories of tests using hermes.

  • ibc send test
  • packet-forward-middleware (PFM) test
  • bypass-min-fee test

Bymass-min-fee test is carried asynchronously:
hermes is not running, and packets are cleared manually, thus hermes can choose to pay fees or not by using different hermes configs.

ibc test and PFM are tested by synchronous transaction.

Therefore in the present e2e test setup, there are two hermes instances.

However, ibc tests and PFM test can be done by asynchronously transaction, and this can simplify the test setup into one hermes instances for asynchronous transactions.

Closing criteria

refactor two hermes instances setup into one in e2e test.

Problem details

@yaruwangway yaruwangway self-assigned this Jun 7, 2023
@yaruwangway yaruwangway added code-hygiene scope: testing Code review, testing, making sure the code is following the specification. labels Jun 12, 2023
@mpoke mpoke added the S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth label Sep 15, 2023
@yaruwangway yaruwangway reopened this Sep 29, 2023
@sainoe sainoe self-assigned this Sep 29, 2023
@yaruwangway yaruwangway removed their assignment Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth scope: testing Code review, testing, making sure the code is following the specification.
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants