Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow arbitrary initial version #298

Closed
erikgrinaker opened this issue Jul 26, 2020 · 0 comments · Fixed by #299
Closed

Allow arbitrary initial version #298

erikgrinaker opened this issue Jul 26, 2020 · 0 comments · Fixed by #299
Assignees

Comments

@erikgrinaker
Copy link
Contributor

erikgrinaker commented Jul 26, 2020

IAVL currently starts from version 1. With non-zero genesis support in Tendermint, applications will need to start from an arbitrary version. Since we already allow both imports at arbitrary versions and deletion of old versions, this is conceptually not a problem.

Suggested API: add Options.InitialHeight, which can be passed to NewMutableTreeWithOpts(). If any versions already exist below InitialHeight, return an error. This is only used during the first SaveVersion() call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant