Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log handshakes as previous state UNINITIALIZED #1688

Closed
1 of 3 tasks
colin-axner opened this issue Jul 11, 2022 · 3 comments
Closed
1 of 3 tasks

Log handshakes as previous state UNINITIALIZED #1688

colin-axner opened this issue Jul 11, 2022 · 3 comments
Labels
good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@colin-axner
Copy link
Contributor

colin-axner commented Jul 11, 2022 •
edited
Loading

Summary

When logging during the INIT and TRYOPEN steps of the handshake for both connection and channel. Change the previous state from NONE to UNINITIALIZED. See comment

Should be applied to both 03-connection and 04-channel handshake steps. Please assign yourself or comment on the issue if you will be handling it. May be backported.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added the type: code hygiene Clean up code but without changing functionality or interfaces label Jul 11, 2022
@colin-axner colin-axner mentioned this issue Jul 11, 2022
Merged
9 tasks
@crodriguezvega
Copy link
Contributor

crodriguezvega commented Jul 11, 2022 •
edited
Loading

Maybe just some extra clarification: as @damiannolan points out in this comment UNINITIALIZED is the default zero value for connection state enum and channel state enum.

@crodriguezvega crodriguezvega added the good first issue Good for newcomers label Jul 11, 2022
@GNaD13
Copy link
Contributor

GNaD13 commented Mar 15, 2023

Hi sir @crodriguezvega , Can I take this issue?

@crodriguezvega
Copy link
Contributor

Hi @GNaD13. Sorry, I missed your message and just saw it now... I think I am going to close this issue now, because its partly solved by #3384 and it will be completely solved with #3385. Thank for volunteering, I hope you can find another issue to work on. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@crodriguezvega @colin-axner @GNaD13