Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nil checks on the controller module for underlying app #2040

Closed
3 tasks
colin-axner opened this issue Aug 18, 2022 · 0 comments · Fixed by #2102
Closed
3 tasks

Add nil checks on the controller module for underlying app #2040

colin-axner opened this issue Aug 18, 2022 · 0 comments · Fixed by #2102
Assignees
Milestone

Comments

@colin-axner
Copy link
Contributor

Summary

Allow the underlying app to be nil in the ics 27 controller module.

Problem Definition

The underlying app is no longer needed in all cases after adding a msg server to controller and allowing the controller module to claim the channel capability.

Proposal

Add nil checks to all calls on the underlying app within the ics27 controller module. Tests should be added for these checks. To test this case, I believe you'll need to substitute the cbs retrieved from the router with a new IBCMiddleware type which contains nil for the app. It might be best to use a boolean var local to the testing function to see if the nil app should be used for the given test case


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants