Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid sequence mismatch when using relayer wallet to sign ibc tx msgs #3264

Closed
3 tasks
colin-axner opened this issue Mar 8, 2023 · 2 comments · Fixed by #3402
Closed
3 tasks

Avoid sequence mismatch when using relayer wallet to sign ibc tx msgs #3264

colin-axner opened this issue Mar 8, 2023 · 2 comments · Fixed by #3402
Assignees
Labels
e2e type: bug Something isn't working as expected

Comments

@colin-axner
Copy link
Contributor

Summary

An indeterminstic failure can be seen here

  testsuite.go:431: 
        	Error Trace:	/home/runner/work/ibc-go/ibc-go/e2e/testsuite/testsuite.go:431
        	            				/home/runner/work/ibc-go/ibc-go/e2e/tests/interchain_accounts/incentivized_test.go:292
        	Error:      	Should not be: 0
        	Test:       	TestIncentivizedInterchainAccountsTestSuite/TestMsgSendTx_FailedBankSend_Incentivized
        	Messages:   	code: 32
        	            	codespace: sdk
        	            	data: ""
        	            	events: []
        	            	gas_used: "0"
        	            	gas_wanted: "0"
        	            	height: "0"
        	            	info: ""
        	            	logs: []
        	            	raw_log: 'account sequence mismatch, expected 9, got 8: incorrect account sequence'
        	            	timestamp: ""
        	            	tx: null
        	            	txhash: B915E76EC510455F9A27ECA78521CFC0E97F6FE3059BEC1CF4A2DC5D96C0F528

Problem Definition

We use the relayer wallet to sign the MsgRegisterCounterpartyPayee which makes sense, but this causes a sequence mismatch since the relayer wallet may be submitting a tx at the same time.

Proposal

Not sure since the MsgRegisterCounterpartyPayee needs to be signed by the relayer wallet. Maybe we can stop the relayer/restart while sending this tx?


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added e2e type: bug Something isn't working as expected labels Mar 8, 2023
@colin-axner colin-axner changed the title Don't use relayer wallets in e2e's for signing ibc transactions Avoid sequence mismatch when using relayer wallet to sign ibc tx msgs Mar 8, 2023
@colin-axner
Copy link
Contributor Author

colin-axner commented Mar 9, 2023

I think we can actually look for a substring match of account sequence mismatch and then retry the tx for MsgRegisterCounterpartyPayee specifically?

@chatton
Copy link
Contributor

chatton commented Mar 14, 2023

I think for now we can specifically retry on the mismatch error, but it might be useful to have a mechanism to retry on one of a list of errors if more pop up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e type: bug Something isn't working as expected
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants